Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @lru_cache to ImageBuildEngine.build #2112

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add @lru_cache to ImageBuildEngine.build #2112

merged 1 commit into from
Jan 18, 2024

Conversation

pingsutw
Copy link
Member

Why are the changes needed?

Remove duplicate logs

What changes were proposed in this pull request?

Add @lru_cache to ImageBuildEngine.build

How was this patch tested?

pyflyte run --remote flyte-example/wf.py wf

Screenshots

Before:
image

After:
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (892b474) 85.77% compared to head (94c8d29) 85.79%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.01%     
==========================================
  Files         313      313              
  Lines       23500    23507       +7     
  Branches     3512     3514       +2     
==========================================
+ Hits        20158    20168      +10     
+ Misses       2734     2730       -4     
- Partials      608      609       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 6279b81 into master Jan 18, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants