Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when multiple configuration plugins are installed #2069

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Error when multiple configuration plugins are installed #2069

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15192c6
Error when multiple configuration plugins are installed
thomasjpfan Dec 22, 2023
dc063a3
Adds semi-colon
thomasjpfan Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flytekit/configuration/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ def _get_plugin_from_entrypoint():

if len(plugins) >= 2:
plugin_names = [p.name for p in plugins]
logger.info(f"Multiple plugins seen for {group}: {plugin_names}")
raise ValueError(
f"Multiple plugins installed {plugin_names}. flytekit only supports one installed plugin at a time."
)

plugin_to_load = plugins[0]
logger.info(f"Loading plugin: {plugin_to_load.name}")
Expand Down
17 changes: 9 additions & 8 deletions tests/flytekit/unit/cli/pyflyte/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import re
from unittest.mock import Mock, patch

import click
import pytest

from flytekit.configuration.plugin import FlytekitPlugin, FlytekitPluginProtocol, _get_plugin_from_entrypoint

Expand All @@ -14,20 +16,19 @@ def test_get_plugin_default(entry_points):


@patch("flytekit.configuration.plugin.entry_points")
def test_get_plugin_load_other_plugin(entry_points, caplog):
loaded_plugin_1 = Mock()
def test_get_plugin_errors_with_multiple_plugins(entry_points, caplog):
entry_1 = Mock()
entry_1.name = "entry_1"
entry_1.load.side_effect = lambda: loaded_plugin_1

entry_2 = Mock()
entry_2.name = "entry_2"
entry_points.side_effect = lambda *args, **kwargs: [entry_1, entry_2]

plugin = _get_plugin_from_entrypoint()
assert plugin is loaded_plugin_1

assert entry_1.load.call_count == 1
assert entry_2.load.call_count == 0
msg = re.escape(
"Multiple plugins installed ['entry_1', 'entry_2']. flytekit only supports one installed plugin at a time."
)
with pytest.raises(ValueError, match=msg):
_get_plugin_from_entrypoint()


class CustomPlugin(FlytekitPlugin):
Expand Down