-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent Metadata Servicer #2012
Merged
pingsutw
merged 34 commits into
flyteorg:master
from
Future-Outlier:agent-metadata-proto-service
Jan 31, 2024
Merged
Agent Metadata Servicer #2012
pingsutw
merged 34 commits into
flyteorg:master
from
Future-Outlier:agent-metadata-proto-service
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
November 30, 2023 14:57
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2012 +/- ##
==========================================
- Coverage 85.79% 85.79% -0.01%
==========================================
Files 313 313
Lines 23507 23618 +111
Branches 3514 3539 +25
==========================================
+ Hits 20168 20262 +94
- Misses 2730 2744 +14
- Partials 609 612 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
3 tasks
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
kumare3
reviewed
Dec 8, 2023
…nto agent-metadata-proto-service Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Dec 17, 2023
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
…nto agent-metadata-proto-service Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Dec 19, 2023
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
force-pushed
the
agent-metadata-proto-service
branch
from
December 19, 2023 23:46
a7908a4
to
cd50544
Compare
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
…nto agent-metadata-proto-service
Signed-off-by: Future Outlier <[email protected]>
…nto agent-metadata-proto-service
pingsutw
reviewed
Jan 13, 2024
…ent-metadata-proto-service
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
pingsutw
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4511
Describe your changes
Implement Agent Metadata Servicer in the agent server.
Check all the applicable boxes
Setup Process
Screenshots
Note to reviewers
Related PRs