Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Metadata Servicer #2012

Merged
merged 34 commits into from
Jan 31, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Nov 30, 2023

Tracking issue

flyteorg/flyte#4511

Describe your changes

Implement Agent Metadata Servicer in the agent server.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

tasks:
  task-plugins:
    enabled-plugins:
      - container
      - sidecar
      - K8S-ARRAY
      - agent-service
  default-for-task-types:
      api_task: agent-service
      airflow: agent-service
      sensor: agent-service
      spark: agent-service
      bigquery_query_job_task: agent-service
      custom_task: agent-service
      container: container
      container_array: K8S-ARRAY
agent-service:
   defaultAgent:
      endpoint: "dns:///localhost:8000"
      insecure: true
      timeouts:
        GetTask: 100s
      defaultTimeout: 100s
  1. start the single binary mode
flytectl demo start --dev
  1. start the agent server
pyflyte serve agent
  1. start the flyte cluster
flyte start --config ./flyte-single-binary-local-dev.yaml

Screenshots

{
   "json":{
      "src":"plugin.go:391"
   },
   "level":"info",
   "msg":"Agent supports task types: [sensor spark airflow task_type_1 task_type_2]",
   "ts":"2023-12-19T22:23:03+08:00"
}

image

Note to reviewers

Related PRs

Signed-off-by: Future Outlier <[email protected]>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6279b81) 85.79% compared to head (e7afa5d) 85.79%.
Report is 26 commits behind head on master.

Files Patch % Lines
flytekit/extend/backend/base_agent.py 64.28% 3 Missing and 2 partials ⚠️
flytekit/extend/backend/agent_service.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
- Coverage   85.79%   85.79%   -0.01%     
==========================================
  Files         313      313              
  Lines       23507    23618     +111     
  Branches     3514     3539      +25     
==========================================
+ Hits        20168    20262      +94     
- Misses       2730     2744      +14     
- Partials      609      612       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Future Outlier added 2 commits December 4, 2023 12:34
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title [WIP] AgentMetadataService [WIP] AgentMetadataServicer Dec 4, 2023
Future Outlier added 2 commits December 4, 2023 13:48
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future Outlier added 4 commits December 10, 2023 18:58
…nto agent-metadata-proto-service

Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
flytekit/extend/backend/agent_service.py Outdated Show resolved Hide resolved
flytekit/extend/backend/agent_service.py Outdated Show resolved Hide resolved
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title [WIP] AgentMetadataServicer AgentMetadataServicer Dec 19, 2023
@Future-Outlier Future-Outlier changed the title AgentMetadataServicer [wip] AgentMetadataServicer Dec 19, 2023
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title [wip] AgentMetadataServicer AgentMetadataServicer Dec 19, 2023
…nto agent-metadata-proto-service

Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier marked this pull request as ready for review December 19, 2023 14:47
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title AgentMetadataServicer Agent Metadata Servicer Dec 19, 2023
flytekit/extend/backend/base_agent.py Outdated Show resolved Hide resolved
flytekit/extend/backend/base_agent.py Outdated Show resolved Hide resolved
Future-Outlier and others added 6 commits December 20, 2023 07:34
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier force-pushed the agent-metadata-proto-service branch from a7908a4 to cd50544 Compare December 19, 2023 23:46
Future Outlier added 4 commits December 20, 2023 07:48
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
flytekit/extend/backend/base_agent.py Outdated Show resolved Hide resolved
flytekit/sensor/sensor_engine.py Outdated Show resolved Hide resolved
Future Outlier and others added 7 commits January 13, 2024 16:52
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
nit
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw and others added 3 commits January 31, 2024 04:37
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@pingsutw pingsutw merged commit 7179d4c into flyteorg:master Jan 31, 2024
81 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants