Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run serialization test individually #1985

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Run serialization test individually #1985

merged 5 commits into from
Nov 22, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 21, 2023

Tracking issue

NA

Docs link

NA

Describe your changes

  • Add a new command test-serialization in the makefile.
  • Add a new GA workflow to run test-serialization

The reason to do this because

  1. It's hard to find the specific test log in the github action since we run 20000+ tests in the build test
  2. It always takes 10-20 mins to run the unit test locally. test-serialization takes 10~15 mins to run. sometimes I want to run all the unit-tests except test-serialization

In test-serialization, we only test to_flyte_idl, from_flyte_idl. In most cases, it won't break when the user changes the code. Therefore, I think it's fine to run it individually.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744c167) 85.80% compared to head (7e65c1e) 85.81%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
+ Coverage   85.80%   85.81%   +0.01%     
==========================================
  Files         313      313              
  Lines       23278    23279       +1     
  Branches     3526     3526              
==========================================
+ Hits        19973    19977       +4     
+ Misses       2702     2701       -1     
+ Partials      603      601       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw marked this pull request as ready for review November 21, 2023 20:53
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Copy link
Collaborator

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea!

@eapolinario eapolinario merged commit 38b15ca into master Nov 22, 2023
75 checks passed
ringohoffman pushed a commit to ringohoffman/flytekit that referenced this pull request Nov 24, 2023
RRap0so pushed a commit to RRap0so/flytekit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants