FIX Fixes codecov upload #1979
Merged
FIX Fixes codecov upload #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
===========================================
+ Coverage 62.54% 82.73% +20.19%
===========================================
Files 313 173 -140
Lines 23249 16967 -6282
Branches 3526 3526
===========================================
- Hits 14540 14038 -502
+ Misses 8286 2326 -5960
- Partials 423 603 +180 ☔ View full report in Codecov by Sentry. |
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Thomas J. Fan <[email protected]>
|
Looking over the logs for codecov, it looks like the coverage is properly uploaded now! |
6 tasks
pingsutw
approved these changes
Nov 21, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* FIX Fixes codecov upload Signed-off-by: Thomas J. Fan <[email protected]> * CI Try updating codecov action Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* FIX Fixes codecov upload Signed-off-by: Thomas J. Fan <[email protected]> * CI Try updating codecov action Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes codecov upload.
Type
Are all requirements met?
Complete description
When looking at the codecov job on the ci, it fails to detect the xml file. This PR explicitly sets the xml file for the codocov GitHub Action to pick up.