Support pip install for vaex on python3.10 #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]>
ericwudayi
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 53.92% 62.78% +8.86%
==========================================
Files 208 308 +100
Lines 18022 23014 +4992
Branches 2281 3493 +1212
==========================================
+ Hits 9718 14449 +4731
- Misses 7893 8143 +250
- Partials 411 422 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Da-Yi Wu <[email protected]>
pingsutw
reviewed
Nov 7, 2023
Signed-off-by: Da-Yi Wu <[email protected]>
|
Congrats on merging your first pull request! 🎉 |
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
Signed-off-by: Da-Yi Wu <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Da-Yi Wu <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Vaex 4.16 now support python 3.10. Change the setup file to support it.
Type
Are all requirements met?
Photos
Tracking Issue
(flyteorg/flyte#3685)