-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image transformer #1901
Add image transformer #1901
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
- Coverage 55.20% 55.09% -0.12%
==========================================
Files 300 301 +1
Lines 22399 22445 +46
Branches 3368 3370 +2
==========================================
Hits 12366 12366
- Misses 9869 9914 +45
- Partials 164 165 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth adding a test where we use Annotated[PIL.Image]
?
from flytekit import task, workflow | ||
|
||
|
||
@task(disable_deck=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you use enable_deck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any other place using PIL.Image
in flytkeit
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
TL;DR
Add an image transformer, so the task can return PIL.Image.Image as an output,
Type
Are all requirements met?
Complete description
My example:
Tracking Issue
flyteorg/flyte#4193
Follow-up issue
NA