-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default project domain in execute launch plan #1894
Conversation
Signed-off-by: troychiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just add this to the top level def execute instead?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 55.23% 55.23% -0.01%
==========================================
Files 300 300
Lines 22381 22385 +4
Branches 3359 3359
==========================================
+ Hits 12363 12364 +1
- Misses 9856 9859 +3
Partials 162 162
☔ View full report in Codecov by Sentry. |
Hi @wild-endeavor, do you mean we can resolve the identifiers before actually classify different types of entities? flytekit/flytekit/remote/remote.py Line 1158 in 74d63d7
|
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
* WIP Signed-off-by: troychiu <[email protected]> * WIP Signed-off-by: troychiu <[email protected]> * fix a test Signed-off-by: troychiu <[email protected]> * Fix Makefile and workflow Signed-off-by: troychiu <[email protected]> * lint Signed-off-by: troychiu <[email protected]> * Update .github/workflows/pythonbuild.yml Co-authored-by: Kevin Su <[email protected]> Signed-off-by: troychiu <[email protected]> * fix bug Signed-off-by: troychiu <[email protected]> * fix bug Signed-off-by: troychiu <[email protected]> * fix a test Signed-off-by: troychiu <[email protected]> * add default project domain in execute launch plan (#1894) Signed-off-by: troychiu <[email protected]> * WIP Signed-off-by: troychiu <[email protected]> * fix tests Signed-off-by: troychiu <[email protected]> * fix test Signed-off-by: troychiu <[email protected]> * Use config file in remote Signed-off-by: Eduardo Apolinario <[email protected]> * Replace other uses of Config.for_sandbox Signed-off-by: Eduardo Apolinario <[email protected]> * Skip joblib integration test Signed-off-by: Eduardo Apolinario <[email protected]> * Skip sqlite test Signed-off-by: Eduardo Apolinario <[email protected]> * remove legacy Signed-off-by: troychiu <[email protected]> --------- Signed-off-by: troychiu <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: troychiu <[email protected]>
* WIP Signed-off-by: troychiu <[email protected]> * WIP Signed-off-by: troychiu <[email protected]> * fix a test Signed-off-by: troychiu <[email protected]> * Fix Makefile and workflow Signed-off-by: troychiu <[email protected]> * lint Signed-off-by: troychiu <[email protected]> * Update .github/workflows/pythonbuild.yml Co-authored-by: Kevin Su <[email protected]> Signed-off-by: troychiu <[email protected]> * fix bug Signed-off-by: troychiu <[email protected]> * fix bug Signed-off-by: troychiu <[email protected]> * fix a test Signed-off-by: troychiu <[email protected]> * add default project domain in execute launch plan (flyteorg#1894) Signed-off-by: troychiu <[email protected]> * WIP Signed-off-by: troychiu <[email protected]> * fix tests Signed-off-by: troychiu <[email protected]> * fix test Signed-off-by: troychiu <[email protected]> * Use config file in remote Signed-off-by: Eduardo Apolinario <[email protected]> * Replace other uses of Config.for_sandbox Signed-off-by: Eduardo Apolinario <[email protected]> * Skip joblib integration test Signed-off-by: Eduardo Apolinario <[email protected]> * Skip sqlite test Signed-off-by: Eduardo Apolinario <[email protected]> * remove legacy Signed-off-by: troychiu <[email protected]> --------- Signed-off-by: troychiu <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
TL;DR
Type
Are all requirements met?
Complete description
When I executed a launch plan with FlyteRemote, it didn't run with default project domain of the remote but needed specified project domain. So, I fixed it with if there is no specified project domain, use default project domain of the remote.
Tracking Issue
flyteorg/flyte#4249
Follow-up issue
NA