Fix map_task sensitive to argument order #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao-Heng Lee <[email protected]>
chaohengstudent
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
sure. will update later. |
Signed-off-by: Chao-Heng Lee <[email protected]>
|
I have added a test about testing task parameter order. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1888 +/- ##
==========================================
+ Coverage 55.06% 55.21% +0.14%
==========================================
Files 296 300 +4
Lines 22250 22393 +143
Branches 3357 3365 +8
==========================================
+ Hits 12252 12364 +112
- Misses 9835 9867 +32
+ Partials 163 162 -1
☔ View full report in Codecov by Sentry. |
eapolinario
reviewed
Oct 13, 2023
Signed-off-by: Chao-Heng Lee <[email protected]>
Signed-off-by: Chao-Heng Lee <[email protected]>
have updated it! thanks for review. |
eapolinario
approved these changes
Oct 14, 2023
pingsutw
approved these changes
Oct 14, 2023
|
thank you, @chaohengstudent ! |
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 20, 2023
* Fix _raw_execute for getting correct len of input value. Signed-off-by: Chao-Heng Lee <[email protected]> * Add test. Signed-off-by: Chao-Heng Lee <[email protected]> * also update with array_node_map_task. Signed-off-by: Chao-Heng Lee <[email protected]> * rename test. Signed-off-by: Chao-Heng Lee <[email protected]> --------- Signed-off-by: Chao-Heng Lee <[email protected]>
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* Fix _raw_execute for getting correct len of input value. Signed-off-by: Chao-Heng Lee <[email protected]> * Add test. Signed-off-by: Chao-Heng Lee <[email protected]> * also update with array_node_map_task. Signed-off-by: Chao-Heng Lee <[email protected]> * rename test. Signed-off-by: Chao-Heng Lee <[email protected]> --------- Signed-off-by: Chao-Heng Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
fixing bug about map_task collecting value length with first key which may be the bound input causing error.
Type
Are all requirements met?
Complete description
Iterate the key and get the one which is not bound.
Get the length of that key's value for mapping.
Tracking Issue
Fixes flyteorg/flyte#4161
Follow-up issue
NA