Add support for min_success_ratio for local map_task execution #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao-Heng Lee <[email protected]>
chaohengstudent
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
+ Coverage 49.57% 51.21% +1.64%
==========================================
Files 251 268 +17
Lines 20123 20928 +805
Branches 3453 3458 +5
==========================================
+ Hits 9976 10719 +743
- Misses 9975 10037 +62
Partials 172 172
☔ View full report in Codecov by Sentry. |
Signed-off-by: Chao-Heng Lee <[email protected]>
…-execution # Conflicts: # flytekit/core/array_node_map_task.py # flytekit/core/map_task.py # tests/flytekit/unit/core/test_array_node_map_task.py # tests/flytekit/unit/core/test_map_task.py
Signed-off-by: Chao-Heng Lee <[email protected]>
pingsutw
reviewed
Oct 30, 2023
…_ratio-for-local-execution Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Oct 30, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
…org#1884) * Add min_success_ratio logic in map_task._raw_execute. Add test. Signed-off-by: Chao-Heng Lee <[email protected]> * also update array_node_map_task. Signed-off-by: Chao-Heng Lee <[email protected]> * add log with error. Signed-off-by: Chao-Heng Lee <[email protected]> --------- Signed-off-by: Chao-Heng Lee <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implement min_success_ratio for
localmap_task execution.Type
Are all requirements met?
Complete description
Implement min_success_ratio at map_task._raw_execute by counting failed tasks.
It will exit once there are no chance to meet the min success tasks.
The output element of failed task will present as
None.(p.s. wonder if just showing the error with the one exceed max failed tasks is reasonable or not?)
Tracking Issue
Fixes flyteorg/flyte#4094
Follow-up issue
NA