-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typing_extension
Any import to typing due to typing_extension
version compatibility
#1877
Conversation
131416a
to
59a337a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update that line instead?
it should be
from typing import Any
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 55.05% 54.85% -0.21%
==========================================
Files 296 293 -3
Lines 22241 22144 -97
Branches 3356 3357 +1
==========================================
- Hits 12244 12146 -98
- Misses 9834 9835 +1
Partials 163 163
☔ View full report in Codecov by Sentry. |
Signed-off-by: H. Furkan Vural <[email protected]>
>=4.4.0
typing_extension
Any import to typing due to typing_extension
version compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lint error, could you run make fmt
locally, and push again
[INFO] This may take a few minutes...
flake8...................................................................Passed
black....................................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook
Fixing /home/runner/work/flytekit/flytekit/flytekit/core/array_node_map_task.py
check yaml...............................................................Passed
Signed-off-by: H. Furkan Vural <[email protected]>
Updated, thanks @pingsutw :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@hfurkanvural , can you confirm which versions of python you tested and python/typing_extensions@7d1aeea is the commit where it was introduced, which indicates that it should have been enabled for all versions of I'm not sure which version on python 3.8 introduced |
I use Python 3.8.8, and run into the same issue |
@eapolinario I use python 3.8.10 |
@pingsutw since codecov is reduced with my latest change, i can not merge the PR. do you have any suggestion to fix that? |
TL;DR
import of type
Any
inflytekit/core/array_node_map_task.py:9
is not supported for thetyping_extensions
libraries previous versions. This version range should fix it, otherwise dependency resolution might cause the following error:Type
Are all requirements met?
Complete description
Due to too broad version range of
typing_extensions
extensions, dependency resolution does not get the right version sometimes. And code base has a specific type which is introduced on version4.4.0
. So this will fix/prevent the import issue.Tracking Issue
NA
Follow-up issue
NA