[Docs]Updated examples for customizing resources #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarMarathon
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
LGTM, but you have to sign the DCO |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
==========================================
- Coverage 55.05% 55.02% -0.03%
==========================================
Files 296 296
Lines 22241 22218 -23
Branches 3356 2172 -1184
==========================================
- Hits 12244 12225 -19
- Misses 9834 9844 +10
+ Partials 163 149 -14 ☔ View full report in Codecov by Sentry. |
LunarMarathon
force-pushed
the
close-4035-customizing-resources
branch
from
941953e to
499b124
Compare
|
Done👍 @kumare3 |
samhita-alla
reviewed
Oct 5, 2023
|
@LunarMarathon, can you fix the DCO? |
added 2 commits
October 6, 2023 13:10
Signed-off-by: LunarMarathon <[email protected]>
Signed-off-by: LunarMarathon <[email protected]>
LunarMarathon
force-pushed
the
close-4035-customizing-resources
branch
from
f0ab9e0 to
f0570ed
Compare
|
@samhita-alla I'm sorry, I completely forgot about signing off the second commit. I've fixed it. |
pingsutw
approved these changes
Oct 6, 2023
samhita-alla
approved these changes
Oct 9, 2023
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes: 4035
Updated the examples to use
with_overrides(requests=Resources(...), limits=Resources(...))instead of what was defined in the older version of flytekit.Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#4035
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/