-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix py38 aync agent service and add async agent test #1866
Merged
pingsutw
merged 13 commits into
flyteorg:master
from
Future-Outlier:fix_py38_ayncio_and_add_async_agent_test
Oct 4, 2023
Merged
Fix py38 aync agent service and add async agent test #1866
pingsutw
merged 13 commits into
flyteorg:master
from
Future-Outlier:fix_py38_ayncio_and_add_async_agent_test
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the databricks agent
[pull] master from flyteorg:master
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
October 3, 2023 06:21
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 50.38% 54.76% +4.37%
==========================================
Files 248 292 +44
Lines 19884 22076 +2192
Branches 3356 2172 -1184
==========================================
+ Hits 10019 12090 +2071
- Misses 9702 9837 +135
+ Partials 163 149 -14
☔ View full report in Codecov by Sentry. |
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Type
Are all requirements met?
Complete description
You can refer to this pr.
#1848
Tracking Issue
#1848
flyteorg/flyte#3936