Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified setup.py in flytekit-mmcloud #1864

Merged
merged 12 commits into from
Oct 2, 2023
Merged

Conversation

helenzhangyc
Copy link
Contributor

The email address of the previous author is going to be deactivated soon, so a change is made to author and author_email.

@welcome
Copy link

welcome bot commented Oct 2, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2f7073d) 55.00% compared to head (88264b3) 54.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   55.00%   54.97%   -0.03%     
==========================================
  Files         296      296              
  Lines       22254    22231      -23     
  Branches     3350     2167    -1183     
==========================================
- Hits        12241    12222      -19     
- Misses       9850     9860      +10     
+ Partials      163      149      -14     

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 4b06628 into flyteorg:master Oct 2, 2023
66 of 68 checks passed
@welcome
Copy link

welcome bot commented Oct 2, 2023

Congrats on merging your first pull request! 🎉

Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
---------

Signed-off-by: Edwin Yu <[email protected]>
Co-authored-by: Edwin Yu <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants