Pyflyte run workflows correctly handles Optional[TYPE] = None #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
pingsutw
previously approved these changes
Sep 25, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1849 +/- ##
==========================================
- Coverage 20.13% 20.13% -0.01%
==========================================
Files 337 337
Lines 32427 32430 +3
Branches 5857 5859 +2
==========================================
Hits 6530 6530
- Misses 25731 25734 +3
Partials 166 166
☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Sep 25, 2023
eapolinario
reviewed
Sep 26, 2023
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
dismissed stale reviews from eapolinario and pingsutw
via
c404605
eapolinario
approved these changes
Sep 26, 2023
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
…rg#1849) * fix pyflyte run handling of default None Signed-off-by: Niels Bantilan <[email protected]> * update tests Signed-off-by: Niels Bantilan <[email protected]> * remote print statements in tests Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Prior to this PR,
pyflyte rundidn't support workflows with a defaultNonevalue.Type
Are all requirements met?
[ ] Code documentation added[ ] Any pending items have an associated IssueComplete description
Updates the
pyflyte runcommand to handleNonevalues in the literal type converter.Tracking Issue
NA
Follow-up issue
NA