Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations for base task compile method #1789

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Add type annotations for base task compile method #1789

merged 2 commits into from
Aug 12, 2023

Conversation

Future-Outlier
Copy link
Member

TL;DR

As the title.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

Follow-up issue

@kumare3
Copy link
Contributor

kumare3 commented Aug 12, 2023

Lgtm, cc @pingsutw

pingsutw
pingsutw approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pingsutw pingsutw merged commit 1a9af18 into flyteorg:master Aug 12, 2023
fg91 pushed a commit that referenced this pull request Aug 15, 2023
@Future-Outlier
Add type hint for base_tas.py compile method (#1789)
5fd2246 
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Future Outlier <[email protected]>
Future-Outlier added a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
@Future-Outlier
Add type hint for base_tas.py compile method (flyteorg#1789)
63e2d0a 
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Future-Outlier @kumare3 @pingsutw