Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type transformer for datetime.date #1786

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add type transformer for datetime.date #1786

merged 1 commit into from
Aug 11, 2023

Conversation

troychiu
Copy link
Member

@troychiu troychiu commented Aug 11, 2023 •
edited
Loading

TL;DR

As title

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Hi community,
This is my first pr in Flyte. I have followed the contribution guide and if there is anything I missed, feel free to leave a comment.
I added a simple transformer for datetime.date.
The to_literal_transformer convert datetime.date to datetime.datetime.
The from_literal_transformer convert datetime.datetime to datetime.date.
Also, I add corresponding tests to test_type_engine.

Tracking Issue

flyteorg/flyte#3026

Follow-up issue

Add datetime.date to https://docs.flyte.org/projects/cookbook/en/latest/auto_examples/type_system/flyte_python_types.html#flytekit-to-flyte-type-mapping

@welcome
Copy link

welcome bot commented Aug 11, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

pingsutw
pingsutw approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pingsutw pingsutw merged commit 2a7c9cb into flyteorg:master Aug 11, 2023
@welcome
Copy link

welcome bot commented Aug 11, 2023

Congrats on merging your first pull request! 🎉

@troychiu troychiu mentioned this pull request Aug 11, 2023
Merged
fg91 pushed a commit that referenced this pull request Aug 15, 2023
@troychiu
#3026: add type datetime.date (#1786)
f520dc1 
Signed-off-by: troychiu <[email protected]>
Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
@troychiu
flyteorg#3026: add type datetime.date (flyteorg#1786)
13eba43 
Signed-off-by: troychiu <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@davidmirror-ops davidmirror-ops mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troychiu @pingsutw