Async Agent #1712
Merged
Async Agent #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Signed-off-by: Kevin Su <[email protected]>
kumare3
reviewed
Jun 28, 2023
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
kumare3
reviewed
Aug 2, 2023
| try: | ||
| tmp = TaskTemplate.from_flyte_idl(request.template) | ||
| inputs = LiteralMap.from_flyte_idl(request.inputs) if request.inputs else None | ||
| agent = AgentRegistry.get_agent(context, tmp.type) | ||
| if agent is None: | ||
| return CreateTaskResponse() | ||
| return agent.create(context=context, inputs=inputs, output_prefix=request.output_prefix, task_template=tmp) | ||
| if agent.asynchronous: | ||
| return await agent.async_create( |
There was a problem hiding this comment.
lets put a
log.debug()
try:
agent.async
except Exception:
log.error
raise
log.debug(done)There was a problem hiding this comment.
the idea is we want to log and know what went wrong in production. Think about how will you make it easier to debug in production and manage in production. Also we should think about adding prometheus metrics or open telemetry (separate PR is ok)
11 tasks
Signed-off-by: Kevin Su <[email protected]>
kumare3
approved these changes
Aug 11, 2023
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Kevin Su <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use async API in the agent service
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA