-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic local execution #1343
Merged
Merged
Dynamic local execution #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario and
pingsutw
as code owners
November 20, 2022 22:11
Signed-off-by: Yee Hing Tong <[email protected]>
kumare3
reviewed
Nov 21, 2022
2 tasks
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 68.85% 68.82% -0.04%
==========================================
Files 287 287
Lines 26453 26530 +77
Branches 2497 2506 +9
==========================================
+ Hits 18215 18260 +45
- Misses 7750 7782 +32
Partials 488 488
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
Nov 22, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Local execution for dynamic workflows never correctly mimicked a production run. Because of the execution context that was set, tasks would return native Python values instead of promises, leading to issues like the
>>
operator not working.This limitation was also introducing runtime bugs in user code because users would use the output of tasks in ways that required them to be native Python values, though this issue was partially mitigated in #1121 by forcing a compilation when run locally.
This bug is also holding up implementation of the human-in-the-loop work. And also makes it so that you can't set node level overrides if you want to run locally.
Type
Are all requirements met?
Complete description
Dynamic tasks are supposed to mimic workflows, so we are taking some code from the workflow local_execute pattern.
Tracking Issue
flyteorg/flyte#3093