Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special characters in snowflake query #1221

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Oct 5, 2022

Signed-off-by: Kevin Su [email protected]

TL;DR

Related to https://flyte-org.slack.com/archives/CP2HDHKE1/p1664792800827789?thread_ts=1663843915.889099&cid=CP2HDHKE1.

snowflake docs

Replace "\n" to "\n" to fix the 400 error.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1221 (0630b13) into master (3758b82) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   68.55%   68.57%   +0.02%     
==========================================
  Files         288      288              
  Lines       26201    26225      +24     
  Branches     2926     2929       +3     
==========================================
+ Hits        17961    17985      +24     
  Misses       7762     7762              
  Partials      478      478              
Impacted Files Coverage Δ
flytekit/core/base_sql_task.py 36.36% <100.00%> (ø)
tests/flytekit/unit/core/test_serialization.py 93.20% <0.00%> (ø)
tests/flytekit/unit/cli/pyflyte/test_register.py 100.00% <0.00%> (ø)
flytekit/core/container_task.py 29.54% <0.00%> (+1.63%) ⬆️
flytekit/clis/sdk_in_container/register.py 82.75% <0.00%> (+1.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eapolinario eapolinario merged commit 91db60e into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants