Fix sql alchemy plugin error `module 'pandas.io' has no attribute 'co…

…mmon' ` (#2249) Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
flyteorg · Jul 25, 2024 · ed0fa55 · ed0fa55
1 parent a731863
commit ed0fa55
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/flytekit/types/structured/basic_dfs.py b/flytekit/types/structured/basic_dfs.py
@@ -34,7 +34,9 @@
 def get_pandas_storage_options(
     uri: str, data_config: DataConfig, anonymous: bool = False
 ) -> typing.Optional[typing.Dict]:
-    if pd.io.common.is_fsspec_url(uri):
+    from pandas.io.common import is_fsspec_url
+
+    if is_fsspec_url(uri):
         return get_fsspec_storage_options(protocol=get_protocol(uri), data_config=data_config, anonymous=anonymous)
 
     # Pandas does not allow storage_options for non-fsspec paths e.g. local.

diff --git a/plugins/flytekit-sqlalchemy/setup.py b/plugins/flytekit-sqlalchemy/setup.py
@@ -4,7 +4,7 @@
 
 microlib_name = f"flytekitplugins-{PLUGIN_NAME}"
 
-plugin_requires = ["flytekit>=1.3.0b2,<2.0.0", "sqlalchemy>=1.4.7", "pandas"]
+plugin_requires = ["flytekit>=1.3.0b2,<2.0.0", "sqlalchemy>=1.4.7", "pandas<=2.1.4"]
 
 __version__ = "0.0.0+develop"