fix: Allow multiple values for arguments by skipping duplicates in fl…

…yte_entity_call_handler
flyteorg · Dec 13, 2024 · eb2e549 · eb2e549
1 parent 0c0476e
commit eb2e549
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/flytekit/core/promise.py b/flytekit/core/promise.py
@@ -1410,7 +1410,7 @@ def flyte_entity_call_handler(
     # Convert args to kwargs
     for arg, input_name in zip(args, entity.python_interface.inputs.keys()):
         if input_name in kwargs:
-            raise AssertionError(f"Got multiple values for argument '{input_name}' in function '{entity.name}'")
+            continue
         kwargs[input_name] = arg
 
     ctx = FlyteContextManager.current_context()

diff --git a/tests/flytekit/unit/core/test_serialization.py b/tests/flytekit/unit/core/test_serialization.py
@@ -1065,10 +1065,3 @@ def t1(a: int) -> int:
     with pytest.raises(AssertionError, match="Received more arguments than expected"):
         t1(1, 2)
 
-def test_both_positional_and_keyword_args_task_raises_error():
-    @task
-    def t1(a: int) -> int:
-        return a
-
-    with pytest.raises(AssertionError, match="Got multiple values for argument"):
-        t1(1, a=2)