build: update requirements for installing python-magic library

- Add `python-magic-bin` as a requirement when installing on Windows - Add `python-magic` as a requirement when installing on Darwin or Linux - Remove `python-magic` as a requirement when installing on Windows Signed-off-by: jason.lai <[email protected]>
flyteorg · Nov 8, 2023 · aea3a47 · aea3a47
1 parent 4b837a8
commit aea3a47
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/dev-requirements.in b/dev-requirements.in
@@ -8,7 +8,6 @@ pytest
 pytest-asyncio
 pytest-cov
 pytest-timeout
-python-magic
 mypy
 pre-commit
 codespell
@@ -28,6 +27,11 @@ torch<=1.12.1; python_version<'3.11'
 # pytorch 2 supports python 3.11
 torch<=2.0.0; python_version>='3.11' or platform_system!='Windows'
 
+# Because DLLs for libmagic are required on Windows,
+# we must specify python-magic-bin when installing the pypi package.
+python-magic-bin; platform_system=='Windows'
+python-magic; (platform_system=='Darwin' or platform_system=='Linux')
+
 pillow
 scikit-learn
 types-protobuf