Set default width if fail to get terminal size (#2558)

* Set default width if fail to get terminal size Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
flyteorg · Jul 25, 2024 · 743ef90 · 743ef90
1 parent 0513445
commit 743ef90
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/flytekit/core/type_engine.py b/flytekit/core/type_engine.py
@@ -1650,7 +1650,7 @@ def to_python_value(self, ctx: FlyteContext, lv: Literal, expected_python_type:
                 res_tag = trans.name
                 found_res = True
             except Exception as e:
-                logger.debug(f"Failed to convert from {lv} to {v}", e)
+                logger.debug(f"Failed to convert from {lv} to {v} with error: {e}")
 
         if is_ambiguous:
             raise TypeError(

diff --git a/flytekit/loggers.py b/flytekit/loggers.py
@@ -140,13 +140,19 @@ def upgrade_to_rich_logging(log_level: typing.Optional[int] = logging.WARNING):
 
     import flytekit
 
+    try:
+        width = os.get_terminal_size().columns
+    except Exception as e:
+        logger.debug(f"Failed to get terminal size: {e}")
+        width = 80
+
     handler = RichHandler(
         tracebacks_suppress=[click, flytekit],
         rich_tracebacks=True,
         omit_repeated_times=False,
         show_path=False,
         log_time_format="%H:%M:%S.%f",
-        console=Console(width=os.get_terminal_size().columns),
+        console=Console(width=width),
     )
 
     formatter = logging.Formatter(fmt="%(filename)s:%(lineno)d - %(message)s")

diff --git a/tests/flytekit/loggers.py b/tests/flytekit/loggers.py
@@ -0,0 +1,11 @@
+import sys
+from subprocess import run
+
+
+def test_error(tmp_path):
+    EXAMPLE = "import flytekit"
+
+    script_path = tmp_path / "script.py"
+    script_path.write_text(EXAMPLE)
+    out = run([sys.executable, script_path], text=True, capture_output=True)
+    assert out.stderr == ""