Update .env.local in README #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kumare3 we have added support for S3. Can you please try it out, or find somebody else who can do that? |
|
This is the issue for this PR right? flyteorg/flyte#332. Mind adding it to the description @kanterov ? |
|
So you already merged the s3 client in. We will try it in some time |
kanterov
force-pushed
the
kanterov-patch-1
branch
from
2a24460 to
f251431
Compare
|
ok let me try it out now |
kanterov
force-pushed
the
master
branch
6 times, most recently
from
0d535a3 to
9a4113b
Compare
sbrunk
approved these changes
Apr 17, 2022
Now when we support S3, use settings compatible with Flyte sandbox Signed-off-by: Hongxin Liang <[email protected]>
Co-authored-by: Sören Brunk <[email protected]> Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
kanterov-patch-1
branch
from
bca5f3a to
c934082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when we support S3, use settings compatible with Flyte sandbox
Fixes flyteorg/flyte#332