Case class for BindingCollection/Map #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
honnix-patch-1
branch
from
81f8eb4 to
7bb1271
Compare
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Oct 19, 2023
| @@ -17,13 +17,12 @@ | |||
| package org.flyte.flytekit | |||
There was a problem hiding this comment.
BTW why these classes are not under flytekitscala package?
There was a problem hiding this comment.
There was a problem hiding this comment.
We cannot make it protected either as it would
* be good for the own object but both implementations deal with list or maps
* of [[SdkBindingData]] and therefore cannot call this method because it is in
* a different class.
Not sure I understand what this refers to.
There was a problem hiding this comment.
I think I understand what this means.
There was a problem hiding this comment.
I tried revising it a bit in a latter commit.
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
honnix-patch-1
branch
from
454bef3 to
a32679d
Compare
andresgomezfrr
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Make Scala
BindingCollectionandBindingMapcase classes.Type
Are all requirements met?
Complete description
Making them case classes to be able to support equality check. They should have been case classes in the first place, so this is a bug fix.
This change should have no user impact because both classes are package private.
Tracking Issue
NA
Follow-up issue
NA