Add typed transform inputs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narape
force-pushed
the
typed-inputs
branch
3 times, most recently
from
39b162e to
517f129
Compare
... flytekit-java compiles but tests fails Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
2 tasks
narape
commented
Jan 24, 2023
flytekit-examples-scala/src/main/scala/org/flyte/examples/flytekitscala/AddQuestionTask.scala
Show resolved
Hide resolved
narape
commented
Jan 24, 2023
| /** | ||
| * Generate an immutable value class that represents {@link AddQuestionTask}'s input, which is a | ||
| * String. | ||
| */ | ||
| @AutoValue | ||
| public abstract static class Input { | ||
| public abstract SdkBindingData<String> greeting(); | ||
|
|
||
| public static Input create(SdkBindingData<String> greeting) { |
There was a problem hiding this comment.
Note to reviewers
Before we were only using the AutoValue to define the type of the task, but now we actually create the auto values to pass it in the apply
narape
commented
Jan 24, 2023
| import javax.annotation.Nullable; | ||
|
|
||
| public class SdkCondition<OutputT> extends SdkTransform<OutputT> { | ||
| public class SdkCondition<OutputT> extends SdkTransform<Void, OutputT> { |
There was a problem hiding this comment.
Note for reviewers
We made a SdkCondition to have no inputs on itself but the transformations going on when, and otherwise cases could have a combination of both:
- SdkTransforms that takes no inputs
- SdkTransforms that takes inputs but the inputs are supplied
All of them should have the same ouput type
narape
commented
Jan 24, 2023
flytekit-java/src/main/java/org/flyte/flytekit/SdkConditions.java
Outdated
Show resolved
Hide resolved
flytekit-java/src/main/java/org/flyte/flytekit/SdkPartialTransform.java
Outdated
Show resolved
Hide resolved
flytekit-java/src/main/java/org/flyte/flytekit/SdkRemoteLaunchPlan.java
Outdated
Show resolved
Hide resolved
flytekit-java/src/main/java/org/flyte/flytekit/SdkRemoteLaunchPlan.java
Outdated
Show resolved
Hide resolved
flytekit-java/src/main/java/org/flyte/flytekit/SdkRemoteLaunchPlan.java
Outdated
Show resolved
Hide resolved
| @@ -91,4 +74,16 @@ public SdkTransform<T> withTimeoutOverride(Duration timeout) { | |||
| public String getName() { | |||
| return getClass().getName(); | |||
| } | |||
|
|
|||
| void checkNullOnlyVoid(@Nullable InputT inputs) { | |||
There was a problem hiding this comment.
Note to reviewers
This method makes sure that the input "nullness" matches the input type:
nullin the only valid value forVoidandUnitSdkTypes- Any other
SdkTypecannot havenull
If you have a better name please suggest it
flytekit-java/src/test/java/org/flyte/flytekit/SdkLaunchPlanRegistrarTest.java
Outdated
Show resolved
Hide resolved
flytekit-local-engine/src/test/java/org/flyte/localengine/examples/TestUnaryIntegerOutput.java
Show resolved
Hide resolved
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
andresgomezfrr
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This feature allows the users to know the specific inputs from a task at development time. This is really important when you are working with a remote task that is developed by other users.
Type
Are all requirements met?
Complete description
This feature allows the users to know the specific inputs from a task at development time. This is really important when you are working with a remote task that is developed by other users. The final goal is to use the input class in the WorkflowBuilder instead of passing the input into the SdkTransform using the withInput(...) method that forces you to know the attribute names of the input class. Example: Fibonacci Workflow
Tracking Issue
Follow-up issue
NA