Block more resource loading to parent #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
commented
Nov 26, 2022
| @@ -63,6 +64,7 @@ public void testFibonacciWorkflow() { | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled | |||
There was a problem hiding this comment.
For some reason this always times out.
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
skip-more-resources
branch
from
715188b to
9f97845
Compare
Signed-off-by: Hongxin Liang <[email protected]>
narape
approved these changes
Nov 28, 2022
andresgomezfrr
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Block more resource loading to parent Signed-off-by: Hongxin Liang <[email protected]> * Make sure it is a folder Signed-off-by: Hongxin Liang <[email protected]> Signed-off-by: Hongxin Liang <[email protected]> Signed-off-by: Andres Gomez Ferrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Block service resource loading to parent.
Type
Are all requirements met?
Complete description
ServiceLoadertries to find resources to understand what classes to load, and for the following scenario, it will fail with a mysteries error message.com.example.Fooexists both in parent and child classpath, in two different jarscom.example.FooImplonly exists in parent classpathServiceLoaderto discover implementation ofcom.example.Foo, usingChildFirstClassLoaderServiceLoaderusesChildFirstClassLoaderto find resources from both child and parent classpath, and in this casecom.example.FooImplis discoveredServiceLoaderverifies whethercom.example.FooImpl(loaded by parent class loader, and its super classcom.example.Foois also loaded by parent class loader; remember there are two copies ofcom.example.Foo?) can be assigned tocom.example.Foo(loaded by child class loader)com.example.Fooloaded by different class loaders, with an error message like "java.util.ServiceConfigurationError: com.example.Foo: com.example.FooImpl not a subtype"Tracking Issue
Closes flyteorg/flyte#3103
Follow-up issue
NA