This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Datacatalog delete artifact #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 18 18
Lines 1377 1377
=======================================
Hits 1015 1015
Misses 311 311
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Dec 15, 2022
MorpheusXAUT
force-pushed
the
datacatalog-delete-artifact
branch
from
3e44057 to
9cc1f12
Compare
|
Rebased onto current |
added 9 commits
January 19, 2023 11:48
Signed-off-by: Nick Müller <[email protected]>
Added new CacheEvictionError message representing an error encountered during eviction of stored data Added new UpdateTaskExecution endpoint for updating task executions, currently only supporting cache eviction Signed-off-by: Nick Müller <[email protected]>
Ran go mod tidy Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
…oints Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
grpc-gateway parsing of URL params does not work for joined endpoint at the moment - fixed in major version upgrade Added extra CacheEvictionErrorCode enum entries Signed-off-by: Nick Müller <[email protected]>
…artifacts to datacatalog Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
datacatalog-delete-artifact
branch
from
9cc1f12 to
e9fb728
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR prepares datacatalog and flyteadmin endpoints for the second part of our cache eviction changes, evicting the cache of a (past) execution.
Type
Are all requirements met?
Complete description
A new
CacheServicewas introduced to flyteadmin's proto definitions. The two currently defined methods allow for cache eviction for anExecutionorTaskExecution. Initially, both endpoints were merged in a single endpoint (since handling in flyteadmin is very similar), however due to an issue ingrpc-gateway < 2.0.1withoneofproperties andadditional_bindings, I've had to split them into two separate endpoints. This could be be merged again once the dependency upgrade has completed, however too many breaking changes would be introduced at the moment.The returned
CacheEvictionErrorsare intended to be displayed in the frontend to provide feedback about cache eviction to the user.Additionally, datacatalog's API was extended by
DeleteArtifact, allowing for an artifact to be deleted from the database/blob storage based on ID or tag.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA