-
Notifications
You must be signed in to change notification settings - Fork 62
Add interruptible override to execution #minor #287
Add interruptible override to execution #minor #287
Conversation
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Allows distinguishment between a value not being provided and the go zerovalue false Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one nit with comments!
Signed-off-by: Nick Müller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 74.77% 74.77%
=======================================
Files 15 15
Lines 991 991
=======================================
Hits 741 741
Misses 218 218
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Not quite sure why the generate test fails, |
Included documentation for in proto generation Signed-off-by: Nick Müller <[email protected]>
This could be due to difference in tooling versions... Make sure you're using the same versions used in CI... Apologies about that |
Signed-off-by: Nick Müller <[email protected]>
973cdbc
to
de51e71
Compare
@EngHabu Just re-generated the same on my Windows instead of Linux machine, seems to be working now... Not sure what exactly changed, as I believe I've installed the identical versions in both environments, but I'll have another look at that tomorrow. |
@EngHabu mind reviewing too? |
* Added interruptible flag for execution to protos Signed-off-by: Nick Müller <[email protected]> * Changed execution interruptible flag to use regular bool Signed-off-by: Nick Müller <[email protected]> * Changed interruptible overrides to use BoolValue Allows distinguishment between a value not being provided and the go zerovalue false Signed-off-by: Nick Müller <[email protected]> * Interruptible flag comment/documentation Signed-off-by: Nick Müller <[email protected]> * Interruptible flag comment/documentation Signed-off-by: Nick Müller <[email protected]> * Removed unescaped quotes from proto comments Included documentation for in proto generation Signed-off-by: Nick Müller <[email protected]> * Re-generated documentation Signed-off-by: Nick Müller <[email protected]>
TL;DR
Adds an
interruptible
flag to theExecutionSpec
, allowing for workflows to be flagged as interruptible for a single execution.Type
Are all requirements met?
Complete description
An additional field has been added to the
ExecutionSpec
, allowing for theinterruptible
flag of a workflow to be override for a single execution (existing overrides on task level still remain in place). Default value offalse
falls back to workflow/task config.The override is internally passed along via the
WorkflowExecutionSpec
in flyteadmin, some interfaces require theLaunchPlanSpec
to implement theinterruptible
flag as well, although it is currently not used.Tracking Issue
flyteorg/flyte#2284
Follow-up issue
NA