Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

new flytestd libe version added #93

Merged
merged 4 commits into from
Jun 15, 2021
Merged

new flytestd libe version added #93

merged 4 commits into from
Jun 15, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jun 14, 2021

TL;DR

  • New version of flytestdlib will remove extra login in flytectl

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #93 (a5580f0) into master (0a2f561) will increase coverage by 35.43%.
The diff coverage is 64.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #93       +/-   ##
===========================================
+ Coverage   34.05%   69.49%   +35.43%     
===========================================
  Files          25       99       +74     
  Lines         693     2160     +1467     
===========================================
+ Hits          236     1501     +1265     
- Misses        441      573      +132     
- Partials       16       86       +70     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/register/examples.go 0.00% <0.00%> (ø)
pkg/commandutils/command_utils.go 100.00% <ø> (ø)
pkg/ext/attribute_match_fetcher.go 100.00% <ø> (ø)
pkg/ext/attribute_match_updater.go 100.00% <ø> (ø)
pkg/ext/attribute_matcher_deleter.go 100.00% <ø> (ø)
pkg/ext/deleter.go 100.00% <ø> (ø)
pkg/ext/execution_fetcher.go 58.82% <ø> (ø)
cmd/config/config_flags.go 23.80% <20.00%> (-5.61%) ⬇️
...clusterresourceattribute/attrdeleteconfig_flags.go 20.00% <20.00%> (ø)
.../clusterresourceattribute/attrfetchconfig_flags.go 20.00% <20.00%> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e568c38...a5580f0. Read the comment docs.

Signed-off-by: Yuvraj <[email protected]>
docs/source/index.rst Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@yindia yindia force-pushed the fix/flytestdlib branch from 0584fab to 6d44b24 Compare June 15, 2021 10:52
@yindia yindia force-pushed the fix/flytestdlib branch from e644049 to a5580f0 Compare June 15, 2021 16:22
@yindia yindia merged commit c43dba8 into master Jun 15, 2021
@yindia yindia deleted the fix/flytestdlib branch June 15, 2021 17:04
yindia added a commit that referenced this pull request Jun 16, 2021
* new flytestd libe version added

Signed-off-by: Yuvraj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants