Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Dep: Bump flyteidl, propeller, plugins, stdlib to 1.10 #439

Closed
wants to merge 2 commits into from

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Oct 30, 2023

TL;DR

Bump flyteidl, flytepropeller, flyteplugins, and flytestdlib dependencies to the newly released 1.10 release.

The new flyteidl version brings the proxy-authorization logic in the admin client required for the GCP Identity Aware Proxy integration to flytectl.

@fg91 fg91 self-assigned this Oct 30, 2023
@fg91 fg91 added the dependencies Pull requests that update a dependency file label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1350bfa) 67.69% compared to head (7f7e7bc) 68.39%.

❗ Current head 7f7e7bc differs from pull request most recent head d04d58d. Consider uploading reports for the commit d04d58d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   67.69%   68.39%   +0.69%     
==========================================
  Files         148      148              
  Lines        6622     5515    -1107     
==========================================
- Hits         4483     3772     -711     
+ Misses       1851     1455     -396     
  Partials      288      288              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 136 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngHabu
Copy link
Contributor

EngHabu commented Oct 30, 2023

Hey @fg91,
I believe some regression was found in 1.10.0 because of the proxy Auth PR. It has since been addressed in a patch but no formal release has been created yet. Can you, therefore, upgrade these dependencies to a7fc66481a52a3428947f6eb4e72930448d3611d instead (latest commit as of the time of this comment)

@fg91
Copy link
Member Author

fg91 commented Oct 30, 2023

Hey @fg91, I believe some regression was found in 1.10.0 because of the proxy Auth PR. It has since been addressed in a patch but no formal release has been created yet. Can you, therefore, upgrade these dependencies to a7fc66481a52a3428947f6eb4e72930448d3611d instead (latest commit as of the time of this comment)

Are you referring to flyteorg/flyte#4295? Sorry I didn't notice this.

I can change the replace to the lastest master commit but from my side this PR could also wait until there is the next official patch release. Any preference?

@EngHabu
Copy link
Contributor

EngHabu commented Oct 31, 2023

yes that's the change!... no problem & no preference.

@fg91 fg91 force-pushed the fg91/dep/bump-flyteidl-1.10 branch from e35b4b8 to d04d58d Compare November 2, 2023 22:21
@fg91 fg91 requested a review from davidmirror-ops November 2, 2023 22:34
@fg91
Copy link
Member Author

fg91 commented Nov 2, 2023

yes that's the change!... no problem & no preference.

Pinned latest master 👍

@fg91 fg91 changed the title Dep: Bum flyteidl, propeller, plugins, stdlib to 1.10 Dep: Bump flyteidl, propeller, plugins, stdlib to 1.10 Nov 3, 2023
@fg91
Copy link
Member Author

fg91 commented Dec 11, 2023

Closing in favor of #447

@fg91 fg91 closed this Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants