Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Adding support for structured dataset and also for node outputs in details flag #390

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

pmahindrakar-oss
Copy link
Contributor

TL;DR

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2757

Follow-up issue

NA

go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #390 (d1cd4bb) into master (5aefa07) will increase coverage by 0.80%.
The diff coverage is 100.00%.

❗ Current head d1cd4bb differs from pull request most recent head 17fd95b. Consider uploading reports for the commit 17fd95b to get more accurate results

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   66.54%   67.34%   +0.80%     
==========================================
  Files         145      145              
  Lines        6265     5234    -1031     
==========================================
- Hits         4169     3525     -644     
+ Misses       1816     1429     -387     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/node_execution.go 81.67% <100.00%> (+2.43%) ⬆️
cmd/get/matchable_workflow_execution_config.go 37.20% <0.00%> (-8.95%) ⬇️
cmd/delete/matchable_attribute_util.go 54.16% <0.00%> (-4.46%) ⬇️
cmd/update/matchable_attribute_util.go 56.00% <0.00%> (-4.00%) ⬇️
cmd/core/cmd_ctx.go 58.82% <0.00%> (-2.29%) ⬇️
cmd/register/examples.go 93.75% <0.00%> (-1.71%) ⬇️
cmd/get/matchable_attribute_util.go 73.68% <0.00%> (-1.32%) ⬇️
cmd/root.go 47.54% <0.00%> (-1.27%) ⬇️
cmd/update/named_entity.go 89.28% <0.00%> (-1.04%) ⬇️
cmd/create/execution.go 93.93% <0.00%> (-0.94%) ⬇️
... and 125 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged the idl change

Signed-off-by: pmahindrakar-oss <[email protected]>
@pmahindrakar-oss pmahindrakar-oss enabled auto-merge (squash) February 22, 2023 18:51
@pmahindrakar-oss pmahindrakar-oss merged commit 217383e into master Feb 22, 2023
@pmahindrakar-oss pmahindrakar-oss deleted the add-outputs branch February 22, 2023 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants