Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Recognize windows arm as a valid OS+arch combination #386

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

eapolinario
Copy link
Contributor

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

windows arm machines are a reality and should be recognized in the install script

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#3290

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #386 (fe4121d) into master (1810234) will increase coverage by 0.77%.
The diff coverage is n/a.

❗ Current head fe4121d differs from pull request most recent head 8b23f7d. Consider uploading reports for the commit 8b23f7d to get more accurate results

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   66.54%   67.32%   +0.77%     
==========================================
  Files         145      145              
  Lines        6265     5230    -1035     
==========================================
- Hits         4169     3521     -648     
+ Misses       1816     1429     -387     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/matchable_workflow_execution_config.go 37.20% <0.00%> (-8.95%) ⬇️
cmd/delete/matchable_attribute_util.go 54.16% <0.00%> (-4.46%) ⬇️
cmd/update/matchable_attribute_util.go 56.00% <0.00%> (-4.00%) ⬇️
cmd/core/cmd_ctx.go 58.82% <0.00%> (-2.29%) ⬇️
cmd/register/examples.go 93.75% <0.00%> (-1.71%) ⬇️
cmd/get/matchable_attribute_util.go 73.68% <0.00%> (-1.32%) ⬇️
cmd/root.go 47.54% <0.00%> (-1.27%) ⬇️
cmd/update/named_entity.go 89.28% <0.00%> (-1.04%) ⬇️
cmd/create/execution.go 93.93% <0.00%> (-0.94%) ⬇️
pkg/filters/util.go 72.72% <0.00%> (-0.81%) ⬇️
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@EngHabu
Copy link
Contributor

EngHabu commented Feb 11, 2023

The question is, do we build for it (or do we need to)? @eapolinario @evalsocket

@yindia
Copy link
Contributor

yindia commented Feb 11, 2023

@EngHabu Yes have publish binary for windows arm https://github.com/flyteorg/flytectl/releases/tag/v0.6.28

@EngHabu EngHabu merged commit 1b2221f into master Feb 11, 2023
@EngHabu EngHabu deleted the update-install-script branch February 11, 2023 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants