This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Archive and Update project command #24
Merged
kumare3
merged 6 commits into
flyteorg:master
from
pmahindrakar-oss:feature/update-project
Feb 7, 2021
Merged
Archive and Update project command #24
kumare3
merged 6 commits into
flyteorg:master
from
pmahindrakar-oss:feature/update-project
Feb 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Feb 3, 2021
kumare3
reviewed
Feb 6, 2021
Once you rebase on #22 +1 from me |
pmahindrakar-oss
force-pushed
the
feature/update-project
branch
from
February 7, 2021 11:39
b990235
to
72232d3
Compare
kumare3
approved these changes
Feb 7, 2021
@@ -4,12 +4,13 @@ A local cluster can be setup via --> https://lyft.github.io/flyte/administrator/ | |||
|
|||
Then, if having trouble connecting to local cluster see the following: | |||
|
|||
|
|||
#1) Find/Set/Verify gRPC port for your local Flyte service: | |||
|
|||
FLYTECTL_GRPC_PORT=`kubectl get service -n flyte flyteadmin -o json | jq '.spec.ports[] | select(.name=="grpc").port'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just needs the envoy ingress now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive and Update project command
Usage
1] Added new command named update
Test Output:
2] Added project as available command under update and flags for activate and archive
3] No project Input
4] Without update options
5] Archive a project
6] Output after archival from get command
7] Activate project
8] Output post activation
9] Project not found
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Not found. Will create one.
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/