Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/dropdown breadcrumbs #799

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

4nalog
Copy link
Member

@4nalog 4nalog commented Jul 19, 2023

Description

This PR fixes navigation breadcrumbs dropdown styling to:

  • not show underline when hovered or active
  • make the entire item in the dropdown clicakble

Signed-off-by: Soham Parekh <[email protected]>
@4nalog 4nalog changed the base branch from master to url-breadcrumbs-feature July 19, 2023 18:05
@4nalog 4nalog requested a review from FrankFlitton July 19, 2023 18:05
@FrankFlitton FrankFlitton merged commit b1144f2 into url-breadcrumbs-feature Jul 19, 2023
@FrankFlitton FrankFlitton deleted the fix/dropdown-breadcrumbs branch July 19, 2023 18:12
FrankFlitton pushed a commit that referenced this pull request Jul 20, 2023
fix: dropdown breadcrumbs

Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>
FrankFlitton pushed a commit that referenced this pull request Jul 25, 2023
fix: dropdown breadcrumbs

Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>
FrankFlitton pushed a commit that referenced this pull request Jul 25, 2023
fix: dropdown breadcrumbs

Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>
FrankFlitton added a commit that referenced this pull request Jul 25, 2023
* chore: new nav bar

Signed-off-by: Frank Flitton <[email protected]>

* chore: navbar quick links

Signed-off-by: Frank Flitton <[email protected]>

* chore: task, workflow, launchplans

Signed-off-by: Frank Flitton <[email protected]>

* chore: remove unused import

Signed-off-by: Frank Flitton <[email protected]>

* chore: fixup navbar integration

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix linter

Signed-off-by: Frank Flitton <[email protected]>

* chore: execution async value

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix types build fail

Signed-off-by: Frank Flitton <[email protected]>

* chore: async self link

Signed-off-by: Frank Flitton <[email protected]>

* chore: add some exports

Signed-off-by: Frank Flitton <[email protected]>

* chore: change to names export

Signed-off-by: Frank Flitton <[email protected]>

* chore: spelling

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix timestamps

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix file upload type failure

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix Executions title not updating

Signed-off-by: Frank Flitton <[email protected]>

* chore: remove depricated types file for dropzone

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix execution launch plan self link

Signed-off-by: Frank Flitton <[email protected]>

* chore: pass custom component

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix named entity cases

Signed-off-by: Frank Flitton <[email protected]>

* chore: different custom component style

Signed-off-by: Frank Flitton <[email protected]>

* chore: dynamic breadcrumb hook with event dispatch

Signed-off-by: Frank Flitton <[email protected]>

* chore: dynamic breadcrumb hook with event dispatch

Signed-off-by: Frank Flitton <[email protected]>

* chore: project and domains link to dashboard

Signed-off-by: Frank Flitton <[email protected]>

* chore: add localstorage setting

Signed-off-by: Frank Flitton <[email protected]>

* chore: get localstorage setting

Signed-off-by: Frank Flitton <[email protected]>

* chore: named entities self links

Signed-off-by: Frank Flitton <[email protected]>

* chore: spacing and scaffolding

Signed-off-by: Frank Flitton <[email protected]>

* chore: grey header color

Signed-off-by: Frank Flitton <[email protected]>

* fix/dropdown breadcrumbs (#799)

fix: dropdown breadcrumbs

Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>

* chore: global inject without emotion

Signed-off-by: Frank Flitton <[email protected]>

* chore: generate id

Signed-off-by: Frank Flitton <[email protected]>

* chore: initial unit tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix incorrect localstore value

Signed-off-by: Frank Flitton <[email protected]>

* chore: named entities execution tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: domain and project util tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix execution list page title 404 ing

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix swipe left to go back

Signed-off-by: Frank Flitton <[email protected]>

* chore: feature flag breadcrumb UI content

Signed-off-by: Frank Flitton <[email protected]>

* chore: set flags from url

Signed-off-by: Frank Flitton <[email protected]>

* chore: set flags from exxternal config

Signed-off-by: Frank Flitton <[email protected]>

* chore: set feature flags from env

Signed-off-by: Frank Flitton <[email protected]>

* chore: get flags from external env

Signed-off-by: Frank Flitton <[email protected]>

* chore: better docs from breadcrumbs interface

Signed-off-by: Frank Flitton <[email protected]>

---------

Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
Co-authored-by: etdotal <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>
jsonporter pushed a commit that referenced this pull request Jul 26, 2023
* chore: new nav bar

Signed-off-by: Frank Flitton <[email protected]>

* feat: url breadcrumbs feature (#784)

* chore: new nav bar

Signed-off-by: Frank Flitton <[email protected]>

* chore: navbar quick links

Signed-off-by: Frank Flitton <[email protected]>

* chore: task, workflow, launchplans

Signed-off-by: Frank Flitton <[email protected]>

* chore: remove unused import

Signed-off-by: Frank Flitton <[email protected]>

* chore: fixup navbar integration

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix linter

Signed-off-by: Frank Flitton <[email protected]>

* chore: execution async value

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix types build fail

Signed-off-by: Frank Flitton <[email protected]>

* chore: async self link

Signed-off-by: Frank Flitton <[email protected]>

* chore: add some exports

Signed-off-by: Frank Flitton <[email protected]>

* chore: change to names export

Signed-off-by: Frank Flitton <[email protected]>

* chore: spelling

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix timestamps

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix file upload type failure

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix Executions title not updating

Signed-off-by: Frank Flitton <[email protected]>

* chore: remove depricated types file for dropzone

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix execution launch plan self link

Signed-off-by: Frank Flitton <[email protected]>

* chore: pass custom component

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix named entity cases

Signed-off-by: Frank Flitton <[email protected]>

* chore: different custom component style

Signed-off-by: Frank Flitton <[email protected]>

* chore: dynamic breadcrumb hook with event dispatch

Signed-off-by: Frank Flitton <[email protected]>

* chore: dynamic breadcrumb hook with event dispatch

Signed-off-by: Frank Flitton <[email protected]>

* chore: project and domains link to dashboard

Signed-off-by: Frank Flitton <[email protected]>

* chore: add localstorage setting

Signed-off-by: Frank Flitton <[email protected]>

* chore: get localstorage setting

Signed-off-by: Frank Flitton <[email protected]>

* chore: named entities self links

Signed-off-by: Frank Flitton <[email protected]>

* chore: spacing and scaffolding

Signed-off-by: Frank Flitton <[email protected]>

* chore: grey header color

Signed-off-by: Frank Flitton <[email protected]>

* fix/dropdown breadcrumbs (#799)

fix: dropdown breadcrumbs

Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>

* chore: global inject without emotion

Signed-off-by: Frank Flitton <[email protected]>

* chore: generate id

Signed-off-by: Frank Flitton <[email protected]>

* chore: initial unit tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix incorrect localstore value

Signed-off-by: Frank Flitton <[email protected]>

* chore: named entities execution tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: domain and project util tests

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix execution list page title 404 ing

Signed-off-by: Frank Flitton <[email protected]>

* chore: fix swipe left to go back

Signed-off-by: Frank Flitton <[email protected]>

* chore: feature flag breadcrumb UI content

Signed-off-by: Frank Flitton <[email protected]>

* chore: set flags from url

Signed-off-by: Frank Flitton <[email protected]>

* chore: set flags from exxternal config

Signed-off-by: Frank Flitton <[email protected]>

* chore: set feature flags from env

Signed-off-by: Frank Flitton <[email protected]>

* chore: get flags from external env

Signed-off-by: Frank Flitton <[email protected]>

* chore: better docs from breadcrumbs interface

Signed-off-by: Frank Flitton <[email protected]>

---------

Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
Co-authored-by: etdotal <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>

* chore: console version bump

Signed-off-by: Frank Flitton <[email protected]>

---------

Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Soham Parekh <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
Co-authored-by: etdotal <[email protected]>
Co-authored-by: Soham Parekh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants