Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow custom subnav #734

Merged
merged 7 commits into from
Apr 15, 2023
Merged

chore: allow custom subnav #734

merged 7 commits into from
Apr 15, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Mar 28, 2023

TL;DR

Allows for passing custom subnavs through settings
image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and olga-union and removed request for a team March 28, 2023 02:04
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #734 (7b8a8b5) into master (530c10d) will decrease coverage by 0.05%.
The diff coverage is 36.84%.

❗ Current head 7b8a8b5 differs from pull request most recent head efc66ce. Consider uploading reports for the commit efc66ce to get more accurate results

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   66.78%   66.74%   -0.05%     
==========================================
  Files         465      465              
  Lines       11411    11418       +7     
  Branches     2108     2104       -4     
==========================================
  Hits         7621     7621              
- Misses       3790     3797       +7     
Impacted Files Coverage Δ
packages/console/src/components/App/App.tsx 0.00% <0.00%> (ø)
...kages/console/src/components/Navigation/NavBar.tsx 0.00% <0.00%> (ø)
...ole/src/components/Navigation/SubNavBarContent.tsx 0.00% <0.00%> (ø)
...ackages/console/src/components/Navigation/index.ts 0.00% <0.00%> (ø)
...ackages/console/src/components/Navigation/utils.ts 0.00% <ø> (ø)
...ages/console/src/components/Theme/colorSpectrum.ts 100.00% <ø> (ø)
packages/console/src/routes/ApplicationRouter.tsx 0.00% <0.00%> (ø)
packages/console/src/common/constants.ts 100.00% <100.00%> (ø)
...ExecutionDetails/ExecutionDetailsAppBarContent.tsx 88.88% <100.00%> (+0.31%) ⬆️
.../Executions/ExecutionDetails/ExecutionMetadata.tsx 94.44% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina enabled auto-merge (squash) April 14, 2023 23:30
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina merged commit 33ee52a into master Apr 15, 2023
@ursucarina ursucarina deleted the carina/subnav branch April 15, 2023 00:02
@ursucarina ursucarina restored the carina/subnav branch April 15, 2023 00:32
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants