Executions View #596

james-union · 2022-09-26T03:53:44Z

On the NodeExecutionsView, three tabs used the different data model and this prevented the future nodes not showing up on the NodeExecutionsTable despite the WorkflowGraph/Timeline showed up.
This PR refactors the data model/flow to three tabs (table, workflow, graph) as the same data.

Type

Bug Fix
Feature
Plugin
Chore

Are all requirements met?

Complete description

Right now, the ExecutionsTable & ExecutionsNodeViews tests are skipped to be considered after this PR is merged. There is a following up issue raised to fix those tests (flyteorg/flyte#604)

Tracking Issue

fixes flyteorg/flyte#603

Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]>

* chore: support for StructuredDataSet Input/Output type Signed-off-by: Carina Ursu <[email protected]> * chore: add tests Signed-off-by: Carina Ursu <[email protected]> * chore: add package Signed-off-by: Carina Ursu <[email protected]> * chore: resolving local package issue Signed-off-by: Carina Ursu <[email protected]> * chore: yarn lock Signed-off-by: Carina Ursu <[email protected]> * chore: stories Signed-off-by: Carina Ursu <[email protected]> * chore: fix associative arrays in copy functionality Signed-off-by: Carina Ursu <[email protected]> * chore: fix scalar stories Signed-off-by: Carina Ursu <[email protected]> * chore: oops Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: revert old viewer to original Signed-off-by: Carina Ursu <[email protected]> * chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove non-null assertion Signed-off-by: Carina Ursu <[email protected]> * chore: fix types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: fix tests Signed-off-by: Carina Ursu <[email protected]> * chore: fix test types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

…scode setup properly (#458) * chore: separate AppInfo * chore: vscode properly understands @flyteconsole * chore: add basics/locale entry * test: add storybooks and tests * test: fix istanbul test-coverage issue by binding babel versions Signed-off-by: Nastya Rusina <[email protected]>

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

* chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove console Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: Nastya <[email protected]>

made the entities component become more generic that can support Workflow, Task, and others added the inputs and outputs to task details page added the versions table in task details page added the version details page added task details link in node side panel Signed-off-by: eugenejahn <[email protected]> Co-authored-by: Eugene Jahn <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionTabContent.tsx

olga-union

Looks much better! Let's bring WorkflowGraph calls to the party in ExecutionTabContent and the structure should be solid!
Don't forget to checkout package files from this branch 😄

packages/zapp/console/src/components/Executions/Tables/NodeExecutionsTable.tsx

Signed-off-by: James <[email protected]>

packages/zapp/console/src/components/Executions/Tables/NodeExecutionsTable.tsx

packages/zapp/console/src/components/WorkflowGraph/WorkflowGraph.tsx

olga-union

🎉 🎉 🎉
There's still some clean-up to do, but no structural changes required. Let's get this PR merge-ready 🥳

* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: James <[email protected]>

olga-union

LGTM!

codecov · 2022-09-30T18:12:02Z

Codecov Report

Merging #596 (be571b2) into devmain (f8cb277) will decrease coverage by 5.84%.
The diff coverage is 22.37%.

@@             Coverage Diff             @@
##           devmain     #596      +/-   ##
===========================================
- Coverage    68.79%   62.95%   -5.85%     
===========================================
  Files          442      443       +1     
  Lines        10478    10478              
  Branches      1796     1799       +3     
===========================================
- Hits          7208     6596     -612     
- Misses        3270     3882     +612

Impacted Files	Coverage Δ
...Executions/ExecutionDetails/ExecutionNodeViews.tsx	`29.26% <0.00%> (-68.21%)`	⬇️
...ponents/Executions/Tables/nodeExecutionColumns.tsx	`23.17% <0.00%> (-74.37%)`	⬇️
...ns/ExecutionDetails/Timeline/ExecutionTimeline.tsx	`22.53% <20.00%> (-1.33%)`	⬇️
...mponents/Executions/Tables/NodeExecutionsTable.tsx	`42.50% <21.05%> (-54.56%)`	⬇️
...xecutions/ExecutionDetails/ExecutionTabContent.tsx	`23.33% <23.33%> (ø)`
.../components/Executions/Tables/NodeExecutionRow.tsx	`30.00% <25.00%> (-70.00%)`	⬇️
...nents/Executions/ExecutionDetails/ExecutionTab.tsx	`64.28% <66.66%> (-6.49%)`	⬇️
...ole/src/components/WorkflowGraph/WorkflowGraph.tsx	`87.50% <100.00%> (+6.10%)`	⬆️
...onsole/src/components/hooks/useConditionalQuery.ts	`22.22% <0.00%> (-77.78%)`	⬇️
.../src/components/Executions/nodeExecutionQueries.ts	`18.66% <0.00%> (-71.34%)`	⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The base branch was changed.

…to james/executions-view

anrusina and others added 30 commits May 17, 2022 18:05

chore: move src to a new location

286e1f8

Signed-off-by: Nastya Rusina <[email protected]>

ci: allow branch to be built again

0efd1df

Signed-off-by: Nastya Rusina <[email protected]>

chore: replace link to github repository to a proper one

b49fed5

Signed-off-by: Nastya Rusina <[email protected]>

ci: basic test and test-coverage setup

9503a4c

Signed-off-by: Nastya Rusina <[email protected]>

chore: add first plugin package

3091c4b

Signed-off-by: Nastya Rusina <[email protected]>

chore: allow to start test from main directory

3573659

Signed-off-by: Nastya Rusina <[email protected]>

ci: update lowest mkdirp version (#423)

8d1fef9

Signed-off-by: Nastya Rusina <[email protected]>

chore: add build scripts for console app (#429)

48a1c92

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

fix: hide the legend (#435)

caaf5c2

Signed-off-by: eugenejahn <[email protected]>

ci: move storybook related packages to top level (#434)

133038a

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

fix: fix issue 386 (#437)

1651a6f

Signed-off-by: eugenejahn <[email protected]>

ci: ensure unified tsconfig and remove mocks, test, stories from build (

eeb551b

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

Make whole row clickable to open TaskExecutionDetails panel (#444)

b6e9941

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

ci: allow to start jest config for all project at once (#447)

b513280

minor: unable to view all the workflow versions (#446)

ecfdd4c

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

chore(tsc): exclude test/stories/mock files only from build (#451)

5b44539

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

ci: ensure that webpack too doesn't include test/mock/specs files (#452)

560b645

Signed-off-by: Nastya Rusina <[email protected]>

ci: minimize babel presence (#457)

acf3cb9

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

fix: update node executions to display map tasks (#455)

38a4e96

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

ci: resolve docker build issues (#462)

c2ee154

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

Chore: Rebase devmain on top of master (#464)

e84a3c0

fix: ensure that admin version is fully shown (#465)

0853680

chore: rebase on top of master

1859cf5

Signed-off-by: Nastya <[email protected]>

fix: trigger release #patch (#477)

42d2632

Signed-off-by: Nastya <[email protected]>

chore: update Readme with python note + package version update (#486)

821299e

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

hotfix ci pipeline (#487)

c25daea

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

olga-union reviewed Sep 27, 2022

View reviewed changes

packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionTabContent.tsx Outdated Show resolved Hide resolved

olga-union suggested changes Sep 27, 2022

View reviewed changes

olga-union reviewed Sep 27, 2022

View reviewed changes

packages/zapp/console/src/components/Executions/Tables/NodeExecutionsTable.tsx Show resolved Hide resolved

fix: detail panel

abac285

Signed-off-by: James <[email protected]>