Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup #389

Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: cleanup #389

merged 1 commit into from
Apr 14, 2022

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Apr 14, 2022

Signed-off-by: Carina Ursu [email protected]

TL;DR

Removing cors_proxy as it is no longer needed

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@ursucarina ursucarina requested review from kumare3, anrusina, a team, jsonporter and olga-union and removed request for a team April 14, 2022 22:10
kumare3
kumare3 previously approved these changes Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #389 (e71be29) into master (a8c0ab8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files         405      405           
  Lines        9059     9059           
  Branches     1599     1599           
=======================================
  Hits         6020     6020           
  Misses       3039     3039           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e684e58...e71be29. Read the comment docs.

Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina changed the title chore: cleanup dead code feat: cleanup Apr 14, 2022
@kumare3 kumare3 self-requested a review April 14, 2022 22:31
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.52.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

akhurana001 pushed a commit that referenced this pull request Apr 26, 2022
Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants