This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add logs and stats to sync loop #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 58.60% 60.14% +1.54%
==========================================
Files 168 168
Lines 16256 13289 -2967
==========================================
- Hits 9527 7993 -1534
+ Misses 5887 4454 -1433
Partials 842 842
Flags with carried forward coverage won't be shown. Click here to find out more. |
EngHabu
requested review from
katrogan,
wild-endeavor,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
katrogan
previously approved these changes
Jun 2, 2023
pkg/clusterresource/controller.go
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| logger.Infof(ctx, "Completed cluster resource creation loop with stats: %+v", stats) |
There was a problem hiding this comment.
Do you think it might be useful to log these stats per namespace as well too, since it's easier to reason about the deltas in created/updated at the template level than remembering they get applied n times across all namespaces?
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
approved these changes
Jun 5, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add logs and stats to sync loop Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add per namespace log as well Signed-off-by: Haytham Abuelfutuh <[email protected]> --------- Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add info logging for when a sync loop starts and ends and add stats at the end of the sync loop to the log.
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#3743