This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Archive and unarchive a project #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
requested review from
anandswaminathan,
EngHabu,
katrogan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
honnix
force-pushed
the
archive-project
branch
from
50eb251 to
e573247
Compare
honnix
commented
Nov 4, 2020
katrogan
reviewed
Nov 4, 2020
No worries. I didn't plan to change API in this PR, to make it a bit smaller. :) I will do that in a follow-up PR. Thanks for pointing it out. |
kumare3
reviewed
Nov 5, 2020
|
hey @honnix this looks good but seems like there are some build issues? |
|
@katrogan Yeah we need flyteorg/flyteidl#88 to be released first. |
|
@honnix oh right, do you have permission to draft a release? otherwise i can go ahead and create one |
|
@katrogan I have permission and I will do that. Just wanted to confirm it is OK I make a release. |
katrogan
approved these changes
Nov 5, 2020
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Use state for a project to archive or activate it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Make a project achievable. Depends on flyteorg/flyteidl#88
Type
Are all requirements met?
Complete description
This PR makes it possible to archive and unarchive a project. Archived project is not visible for
listbut visible forget, and it is treated as an invalid project. Archived project is possible to update so that it can be unarchived.@kumare3 PTAL and see whether this is on the right track. Thanks a lot.
Tracking Issue
flyteorg/flyte#569
Follow-up issue
NA