Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use id in queries #5948

Closed
wants to merge 1 commit into from
Closed

Use id in queries #5948

wants to merge 1 commit into from

Conversation

katrogan
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan closed this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.00%. Comparing base (54a4ad9) to head (3d65d11).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5948      +/-   ##
==========================================
- Coverage   36.84%   33.00%   -3.85%     
==========================================
  Files        1309     1012     -297     
  Lines      131025   107164   -23861     
==========================================
- Hits        48274    35367   -12907     
+ Misses      78559    68664    -9895     
+ Partials     4192     3133    -1059     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (-0.05%) ⬇️
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.00% <ø> (-0.03%) ⬇️
unittests-flytestdlib 55.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant