extend pod customization to include init containers #5685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5685 +/- ##
==========================================
- Coverage 36.17% 36.17% -0.01%
==========================================
Files 1302 1303 +1
Lines 109556 109672 +116
==========================================
+ Hits 39630 39670 +40
- Misses 65786 65856 +70
- Partials 4140 4146 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Samhita Alla <[email protected]>
pingsutw
reviewed
Aug 22, 2024
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Sep 3, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* apply pod config to init containers Signed-off-by: Samhita Alla <[email protected]> * remove container Signed-off-by: Samhita Alla <[email protected]> * add test Signed-off-by: Samhita Alla <[email protected]> * Add bool to check init containers Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* apply pod config to init containers Signed-off-by: Samhita Alla <[email protected]> * remove container Signed-off-by: Samhita Alla <[email protected]> * add test Signed-off-by: Samhita Alla <[email protected]> * Add bool to check init containers Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
* apply pod config to init containers Signed-off-by: Samhita Alla <[email protected]> * remove container Signed-off-by: Samhita Alla <[email protected]> * add test Signed-off-by: Samhita Alla <[email protected]> * Add bool to check init containers Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Extends pod configuration to include init containers, ensuring that all containers in the pod, including init containers, receive the necessary customizations.
This will be especially useful for the ollama plugin to materialize
{{.input}}in the pod template's init container command.What changes were proposed in this pull request?
Adds a dedicated loop to handle init containers, ensuring that template values are properly materialized for all containers in the pod specification.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link