Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the support for the Java/Scala SDK in the docs #5582

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

Support for flytekit-java is driven by the community, so let's reflect that in the documentation.

What changes were proposed in this pull request?

Remove the first-class support from the docs, instead mention that flytekit-java is community-driven.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.91%. Comparing base (3082cd3) to head (5103d77).
Report is 119 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
+ Coverage   35.02%   35.91%   +0.88%     
==========================================
  Files        1204     1301      +97     
  Lines      104634   109403    +4769     
==========================================
+ Hits        36653    39288    +2635     
- Misses      64065    66018    +1953     
- Partials     3916     4097     +181     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.74% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.75% <ø> (ø)
unittests-flytestdlib 55.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 63f8307 into master Jul 23, 2024
50 checks passed
@pingsutw pingsutw deleted the eapolinario-patch-2 branch July 23, 2024 19:57
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants