Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated map task information to indicate array node is now the default and optional return type #5561

Conversation

pryce-turner
Copy link
Contributor

Updated docs to be in line with current array node map task functionality

…t, added optional return value for min success ratio

Signed-off-by: pryce-turner <[email protected]>
@pryce-turner pryce-turner enabled auto-merge (squash) July 15, 2024 22:23
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (81afb76) to head (24a663c).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5561      +/-   ##
==========================================
- Coverage   60.98%   60.98%   -0.01%     
==========================================
  Files         796      796              
  Lines       51647    51647              
==========================================
- Hits        31498    31497       -1     
- Misses      17249    17250       +1     
  Partials     2900     2900              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pryce-turner pryce-turner merged commit c1563d7 into master Jul 16, 2024
50 checks passed
@pryce-turner pryce-turner deleted the pryce/se-73-fix-map_task-docs-to-reflect-optional-outputs-when-setting branch July 16, 2024 03:45
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
…t, added optional return value for min success ratio (flyteorg#5561)

Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants