Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flytefile.md #5428

Merged
merged 2 commits into from
May 29, 2024
Merged

Update flytefile.md #5428

merged 2 commits into from
May 29, 2024

Conversation

wild-endeavor
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <[email protected]>
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (75b33f8) to head (668ef1d).
Report is 138 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5428      +/-   ##
==========================================
- Coverage   61.99%   61.09%   -0.90%     
==========================================
  Files         611      793     +182     
  Lines       36388    51169   +14781     
==========================================
+ Hits        22559    31263    +8704     
- Misses      11863    17034    +5171     
- Partials     1966     2872     +906     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.86% <ø> (?)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.34% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (+0.02%) ⬆️
unittests-flytestdlib 65.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario mentioned this pull request May 29, 2024
3 tasks
eapolinario
eapolinario previously approved these changes May 29, 2024
@eapolinario
Copy link
Contributor

eapolinario commented May 29, 2024

another error:

/home/runner/work/flyte/flyte/flyte/docs/user_guide/extending/custom_types.md:10079:Line number spec is out of range (1 - 119)

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor enabled auto-merge (squash) May 29, 2024 23:31
@wild-endeavor wild-endeavor merged commit 22d81c6 into master May 29, 2024
49 of 50 checks passed
@wild-endeavor wild-endeavor deleted the wild-endeavor-patch-1 branch May 29, 2024 23:42
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants