Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] [compiler] Support non-Any Python types as Any input in workflows #5408

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flyteidl/clients/go/assets/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions flyteidl/gen/pb-es/flyteidl/core/types_pb.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 28 additions & 24 deletions flyteidl/gen/pb-go/flyteidl/core/types.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion flyteidl/gen/pb-js/flyteidl.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions flyteidl/gen/pb-js/flyteidl.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flyteidl/gen/pb_python/flyteidl/core/types_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions flyteidl/gen/pb_python/flyteidl/core/types_pb2.pyi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions flyteidl/gen/pb_rust/flyteidl.core.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions flyteidl/protos/flyteidl/core/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ enum SimpleType {
BINARY = 7;
ERROR = 8;
STRUCT = 9;
ANY = 10;
}

// Defines schema columns and types to strongly type-validate schemas interoperability.
Expand Down
14 changes: 13 additions & 1 deletion flytepropeller/pkg/compiler/validators/typing.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,19 @@ func getTypeChecker(t *flyte.LiteralType) typeChecker {
}
}

func AreTypesCastable(upstreamType, downstreamType *flyte.LiteralType) bool {
func isTypeAny(t *flyte.LiteralType) bool {
if simpleType, ok := t.GetType().(*flyte.LiteralType_Simple); ok {
return simpleType.Simple == flyte.SimpleType_ANY
}

return false
}

func AreTypesCastable(upstreamType *flyte.LiteralType, downstreamType *flyte.LiteralType) bool {
if isTypeAny(downstreamType) {
return true
}

typeChecker := getTypeChecker(downstreamType)

// if upstream is a singular union we check if the downstream type is castable from the union variant
Expand Down
12 changes: 12 additions & 0 deletions flytepropeller/pkg/compiler/validators/typing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ func TestSimpleLiteralCasting(t *testing.T) {
assert.True(t, castable, "Integers should be castable to other integers")
})

t.Run("IntegerToAny", func(t *testing.T) {
castable := AreTypesCastable(
&core.LiteralType{
Type: &core.LiteralType_Simple{Simple: core.SimpleType_INTEGER},
},
&core.LiteralType{
Type: &core.LiteralType_Simple{Simple: core.SimpleType_ANY},
},
)
assert.True(t, castable, "Integers should be castable to Any")
})

t.Run("IntegerToFloat", func(t *testing.T) {
castable := AreTypesCastable(
&core.LiteralType{
Expand Down
Loading