Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databricks): Handle FAILED state as retryable error #5277

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Apr 23, 2024

Tracking issue

https://flyte-org.slack.com/archives/C05BN3A92SE/p1713794999621399

Why are the changes needed?

Flyte won't retry the Databricks job

What changes were proposed in this pull request?

Make Databricks task retryable

How was this patch tested?

local sandbox

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

@pingsutw pingsutw marked this pull request as draft April 23, 2024 16:34
Copy link

@rambrus rambrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingsutw pingsutw self-assigned this Apr 27, 2024
@pingsutw pingsutw marked this pull request as ready for review April 27, 2024 03:37
@pingsutw pingsutw merged commit f32132b into master Apr 29, 2024
46 checks passed
@pingsutw pingsutw deleted the fix-databricks-plugin-1 branch April 29, 2024 04:34
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants