Fix support for limit-namespace in FlytePropeller #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:L
wild-endeavor
approved these changes
Apr 19, 2024
|
thank you @hamersaw and @MortalHappiness |
pingsutw
approved these changes
Apr 19, 2024
3 tasks
fg91
reviewed
May 21, 2024
| }, | ||
| } | ||
| if err := r.cache.List(ctx, &list); err != nil { | ||
| logger.Warnf(ctx, "failed to list objects for %s.%s: %v", r.gvk.Kind, r.gvk.Version, err) |
There was a problem hiding this comment.
@hamersaw I'm seeing this log line a lot since we upgraded to 1.12 (45k times in 5 days). For instance:
failed to list objects for PyTorchJob.v1: no matches for kind "PyTorchJob" in version "v1"The CRD does exist in the cluster:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
...
name: pytorchjobs.kubeflow.org
spec:
group: kubeflow.org
names:
kind: PyTorchJob
listKind: PyTorchJobList
plural: pytorchjobs
singular: pytorchjob
scope: Namespaced
versions:
- ...
name: v1Tasks using the pytorch plugin also work.
Do you know what the reason could be for the cache not being aware of the pytorchjob crd?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes #5087
Why are the changes needed?
Refer to issue ^^ for in-depth explanation of problem.
What changes were proposed in this pull request?
Instead of back-pedaling from the informer to retrieve the object cache for listing k8s objects, this PR updates the plugin object monitoring mechanism to issue queries directly to the cache using the k8s object kind and version.
How was this patch tested?
locally with varying configuration.
Setup process
NA
Screenshots
NA
Check all the applicable boxes
Related PRs
NA
Docs link
NA