Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make link error #5175

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

novahow
Copy link
Contributor

@novahow novahow commented Apr 3, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

image

link doesn't seem like a valid target, perhaps it's a typo and it should be make lint instead.

What changes were proposed in this pull request?

Change make link to make lint

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: novahow <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working documentation Improvements or additions to documentation labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.15%. Comparing base (dc1294e) to head (32c6a4c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5175      +/-   ##
==========================================
+ Coverage   59.11%   59.15%   +0.03%     
==========================================
  Files         645      645              
  Lines       55574    54992     -582     
==========================================
- Hits        32852    32529     -323     
+ Misses      20129    19870     -259     
  Partials     2593     2593              
Flag Coverage Δ
unittests 58.69% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2024
@eapolinario eapolinario merged commit 5b64aeb into flyteorg:master Apr 4, 2024
48 checks passed
@novahow novahow deleted the docs/make_link_typo branch April 4, 2024 04:32
Jeinhaus pushed a commit to Jeinhaus/flyte that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants